https://bugzilla.redhat.com/show_bug.cgi?id=2085444 --- Comment #53 from Charalampos Stratakis <cstratak@xxxxxxxxxx> --- (In reply to xiangquan.liu from comment #52) > (In reply to Charalampos Stratakis from comment #51) > > (In reply to Yunying Sun from comment #49) > > > Sorry for the delayed update. After the license change and various compiling > > > errors against rawhide being fixed, new version of spec and srpm are ready > > > for review now. > > > > > > SPEC: https://yunyings.fedorapeople.org/sgxsdk.spec > > > SRPM: https://yunyings.fedorapeople.org/sgxsdk-2.19.100.0-1.fc39.src.rpm > > > Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=99176101 > > > > > > Please help to review it again. Thanks! > > > > Some minor things. > > > > The "Requires" should go after the "BuildRequires". > Agree to change it. > > > Consider using the %autosetup macro instead of the %setup one. > > $ cat /etc/os-release > NAME="Fedora Linux" > VERSION="39 (Rawhide Prerelease)" > ID=fedora > VERSION_ID=39 > > $ rpmbuild --eval=%autosetup > error: lua script failed: attempt to index a nil value > > I did an experiment on fedora 39 and found %autosetup macro value is nil. So > could you please point how to use it? > %autosetup is a drop-in replacement for %setup, adding some more convenience for possible future patches: https://rpm-software-management.github.io/rpm/manual/autosetup.html > > Now the way you're creating the source strikes me a bit weird. So you get > > the github tarball, run a script and generate a different tarball that then > > is uploaded to some server? Isn't there a canonical release on github or > > somewhere else for that? I'll let other pitch in on that, however if you'd > > go that way the relevant script should be added in the source rpm alongside > > the SPEC and the process of creating the sources explained on a comment > > inside the SPEC. > > > > An example of modifying the sources through instructions from the SPEC: > > https://src.fedoraproject.org/rpms/python-setuptools/pull-request/96#_1__6 > > > > And another example of having a script in the package tree to create > > modified sources (vendor_rust.py in this case): > > https://src.fedoraproject.org/rpms/python-cryptography/tree/rawhide > > If my understanding is right, we discussed this question before. There are > some pre-build binaries like aes which need to be downloaded first. Could you point me to those discussions? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2085444 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
