https://bugzilla.redhat.com/show_bug.cgi?id=2189633 --- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Neal Gompa from comment #2) > Please don't use the forge macros Done. > > %global pkgroot /usr/lib/mkosi-initrd > 1. Why is this in the middle of the spec? It's defined right above the first use. It's just a helper variable to avoid repeating the same thing a few times. > 2. Why isn't this "%{_prefix}/lib"? > > > /usr/lib/kernel/install.d/50-mkosi-initrd.install > > Please use "%{_prefix}/lib" I changed it to use %{_prefix}. (Though I'm not convinced that this change makes sense. kernel-install doesn't support relocation. Various paths for plugins cannot be changed easily, they are documented and fixed in the code. So if in fact anyone tried to use a different %_prefix, this package wouldn't work at all. I know that using %_prefix is the received wisdom, but really, for many cases it doesn't do anything except obfuscate.) > 3. Why is this in /usr/lib and not /usr/libexec? The package is mostly some config files, so /usr/lib/<package> seems appropriate. This also follows the general systemd style. > License file is missing. Oops. I added it now upstream. Spec URL: https://in.waw.pl/~zbyszek/fedora/mkosi-initrd.spec SRPM URL: https://in.waw.pl/~zbyszek/fedora/mkosi-initrd-0.20230506g6ba68f1-1.fc39.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2189633 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
