https://bugzilla.redhat.com/show_bug.cgi?id=1830712 Andrea Perotti <aperotti@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(carl@xxxxxxxxxx) --- Comment #31 from Andrea Perotti <aperotti@xxxxxxxxxx> --- (In reply to Carl George 🤠 from comment #30) > In your copr build log your cmake command is getting the flag > -DBUILD_TESTING:BOOL=OFF. That is because your cmake command in %build is > setting that ON/OFF based on the wrong macro. `%bcond tests 1` sets > `%with_tests` to 1, not `%tests`. You can fix that like this: Ah, thanks! I've addressed it > I also noticed that the license field still refers to GFDL. Which files are licensed under the GFDL? None, you're right. I've updated it. I've also understood the origin of the problem with the gui tests, and I've opened an upstream bug: https://bugs.kde.org/show_bug.cgi?id=469342 In the meantime it's disabled. SPEC and SRPMS have been updated: Spec URL: https://raw.githubusercontent.com/andreamtp/kronometer/master/kronometer.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/andreamtp/kronometer/fedora-38-x86_64/05872555-kronometer/kronometer-2.3.0-1.fc38.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1830712 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
