[Bug 1830712] Review Request: kronometer - A simple KDE stopwatch application

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1830712

Carl George 🤠 <carl@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(carl@xxxxxxxxxx)  |



--- Comment #30 from Carl George 🤠 <carl@xxxxxxxxxx> ---
In your copr build log your cmake command is getting the flag
-DBUILD_TESTING:BOOL=OFF.  That is because your cmake command in %build is
setting that ON/OFF based on the wrong macro.  `%bcond tests 1` sets
`%with_tests` to 1, not `%tests`.  You can fix that like this:

-  -DBUILD_TESTING:BOOL=%{?tests:ON}%{!?tests:OFF}
+  -DBUILD_TESTING:BOOL=%{?with_tests:ON}%{!?with_tests:OFF}


I also noticed that the license field still refers to GFDL.  Which files are
licensed under the GFDL?


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1830712
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux