[Bug 2187061] Review Request: python-fvs - File Versioning System with hash comparison and data storage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2187061



--- Comment #13 from Sandro <gui1ty@xxxxxxxxxxxxx> ---
Thank you for the review!

> Notes:
> 
> (Please fix before importing)
> 
> - [!] The `%description %_description` lines are not properly separated. For
> consistency, there should be 1-2 empty lines before and after these blocks
> just like there is e.g. between %build and %install. They're separate
> sections.
> - [!] For consistency, there should be two empty lines between %prep and
> %generate_buildrequires. %generate_buildrequires is a completely separate
> section, so it should be delaminated in the same way as %build and %install
> are.

I tidied up the spec file and put two empty lines between all sections.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2187061
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux