[Bug 2187061] Review Request: python-fvs - File Versioning System with hash comparison and data storage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2187061

Maxwell G <maxwell@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+



--- Comment #12 from Maxwell G <maxwell@xxxxxxx> ---
Maxwell's Python Package Review Template
==============

Notes:

(Please fix before importing)

- [!] The `%description %_description` lines are not properly separated. For
consistency, there should be 1-2 empty lines before and after these blocks just
like there is e.g. between %build and %install. They're separate sections.
- [!] For consistency, there should be two empty lines between %prep and
%generate_buildrequires. %generate_buildrequires is a completely separate
section, so it should be delaminated in the same way as %build and %install
are. 

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The License tag reflects the package contents and uses the correct
identifiers.
- [x] The package builds successfully in mock.
- [x] The package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.

- [-] The package runs tests in %check.
Upstream does not provide unit tests, so %pyproject_check_import is used.

- [x] The latest version is packaged or packaging an earlier version is
justified.

- [x] Packager considers avoiding confusing `%foo_name` macros. (Not a blocker)

Packager considered and chose to keep %pypi_name.

- [x] Libraries: The package name has a `python3-` prefix and uses the
canonical project name
- [-] Applications: A `python3-` prefix is not used

Packager used the correct naming scheme for a library package.

- [x] The pyproject macros are used
- [x] There are no bundled libraries
- [x] The package complies with the Python and general Packaging Guidelines.

Package approved!

On import, don't forget to add the package to release-monitoring.org and
reference the review bug in the changelog/bodhi update. The release should
start at 1 with a changelog entry / commit message similar to "Initial import.
Closes rhbz#2187061." You can also give @python-packagers-sig `commit` ACLs if
you wish.

Thanks!


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2187061
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux