[Bug 2187061] Review Request: fvs - File Versioning System with hash comparison and data storage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2187061



--- Comment #9 from Maxwell G <maxwell@xxxxxxx> ---
Nobody's going to make you rename the package later for this kind of thing. As
long as you use one of the allowed naming schemes based on your best judgement,
you're in the clear :).

To me, it seems like this is mainly a library, and that's why you're packaging
it. From what I can tell, this was purpose built for Bottles to use as a
library. The CLI was added after the rest of the library code [1]. On the other
hand, vkbasalt-cli is billed as a CLI application, so I'd name the package
vkbassalt-cli and add `%py_provides vkbassalt`.

> Well, the project name needs to be normalized. So, if we are going with a library package the names should be python-fvs and python3-fvs respectively.

That's correct and what I meant to suggest! I'd create a python-fvs component
with a python3-fvs subpackage. The python3-fvs subpackage can have `Provides:
fvs = %{version}-%{release}`. If you prefer the other way around, that's fine
with me as well.

[1]:
https://github.com/mirkobrombin/FVS/commit/b447058773e29fd7adab6d585ae08c32f4565e26


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2187061
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux