[Bug 2187061] Review Request: fvs - File Versioning System with hash comparison and data storage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2187061



--- Comment #8 from Sandro <gui1ty@xxxxxxxxxxxxx> ---
Thank you for the feedback.

I think it boils down to what the primary purpose of this package is. Honestly,
I don't feel confident in deciding that question. IIRC, it has been developed
by one of the Bottles developers for a specific need in Bottles. Bottles uses
the library.

> In this case, it seems `python3-FVS` (as a subpackage of an `python-FVS` SRPM) is the correct naming.

Well, the project name needs to be normalized. So, if we are going with a
library package the names should be python-fvs and python3-fvs respectively.

I know you have a ton more experience packaging than I do, but I still don't
feel confident if this is primarily an app or a library. Looking at the project
description - https://pypi.org/project/FVS/ - it appears to provide both: app
and library. So, I'm inclined to go with the application naming advice:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_application_naming,
in particular:

"Consider adding a virtual provide according to Library naming above (e.g.
python3-PROJECTNAME), if it would help users find the package."

Should I ask for some more advice on the Python list perhaps? I definitely want
to avoid having to rename the package later.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2187061
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux