Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: moodbar - Identifies the "mood" of your music files https://bugzilla.redhat.com/show_bug.cgi?id=251950 ------- Additional Comments From debarshi.ray@xxxxxxxxx 2007-12-30 00:50 EST ------- >> xx - follows Package Naming Guidelines >> + although the Debian package is named 'moodbar', PLD-Linux, OpenSUSE and >> FreeBSD call it 'gstreamer-plugins-moodbar'; in fact the README says Moodbar is >> the algorithm and the package contains a GStreamer plugin and an application -- >> what do you think? > Our guideline is "follow the tarball's name", so I'd rather go with "moodbar". Umm... We have gstreamer-plugins-farsight, farsight and farsight-devel in Fedora. However they are distributed as separate plugins. Would it make sense to split this into moodbar and gstreamer-plugins-moodbar, or you consider it as an overkill? >> + remove the versioned BuildRequires since both F-7 and F-8 have >> gstreamer-devel >= 0.10 > I'd rather keep it, in case someone wants to rebuild it on an older > distribution, or in a spinoff of Fedora which would have and older gstreamer. http://fedoraproject.org/wiki/Packaging/Guidelines?highlight=%28Packaging%29#Requires says: "As a rule of thumb, if the version is not required, don't add it just for fun." But that might be a suggestion and not a requirement. I will leave this to your judgement. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review