Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: moodbar - Identifies the "mood" of your music files https://bugzilla.redhat.com/show_bug.cgi?id=251950 ------- Additional Comments From gauret@xxxxxxx 2007-12-29 04:34 EST ------- > xx - follows Package Naming Guidelines > + although the Debian package is named 'moodbar', PLD-Linux, OpenSUSE and > FreeBSD call it 'gstreamer-plugins-moodbar'; in fact the README says Moodbar is > the algorithm and the package contains a GStreamer plugin and an application -- > what do you think? Our guideline is "follow the tarball's name", so I'd rather go with "moodbar". > xx - package meets Packaging Guidelines > + consider using %{version} in Source0 to avoid bumping it every time Okay, why not. > + remove the versioned BuildRequires since both F-7 and F-8 have > gstreamer-devel >= 0.10 I'd rather keep it, in case someone wants to rebuild it on an older distribution, or in a spinoff of Fedora which would have and older gstreamer. > + consider using '%configure --disable-static' to avoid building the static > library Done. > + consider using 'INSTALL="%{__install} -p"' as: > make install INSTALL="%{__install} -p" DESTDIR=$RPM_BUILD_ROOT Done. > xx - package functions as expected > + moodbar crashes -- Debian package has a patch to fix incorrect interaction > with GLib threading system Added. Thanks a lot for you review ! http://gauret.free.fr/fichiers/rpms/fedora/moodbar/moodbar-0.1.2-2.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review