[Bug 2080743] Review Request: rust-domain - DNS library for Rust

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2080743



--- Comment #16 from Petr Menšík <pemensik@xxxxxxxxxx> ---
Spec URL:
https://raw.githubusercontent.com/pemensik/domain/fedora/packaging/fedora/rust-domain.spec
SRPM URL:
https://pemensik.fedorapeople.org/srpm/rust-domain-0.7.2-1.fc39.src.rpm

(In reply to Fabio Valentini from comment #15)
> 1. You should regenerate the package with the latest rust2rpm (i.e. v24).
> 
> This regeneration step is also necessary for every version update (to ensure
> that RPM subpackages <-> cargo features are mapped correctly).
> This will also drop "ExclusiveArch:  %{rust_arches}", which is no longer
> necessary, and has been removed from the Packaging Guidelines.
done, reuploaded minimal changes
> 
> 2. Where is this forgeurl coming from?
> > %global forgeurl0 https://github.com/NLnetLabs/domain
> > VCS:            git:%{forgeurl0}
> 
> You'd need to manually keep this maintained, as it will be dropped by any
> subsequent package updates.
> Is there a specific reason why you added this?
I just want to keep in spec direct link to place for reporting issues and
primary source.
Those were added by hand. I will leave them there for now.
> 
> ===
> 
> Other than those two points, the package now looks good to me.

I am keeping:
# https://bugzilla.redhat.com/show_bug.cgi?id=1869980
ExcludeArch: %{power64} s390 s390x

hope that is okay. However I have tried borrowing ppc64le machine to test it,
it seems te library itself prepares fine. Even test do pass on that platform,
because no tests cover validation or tsig features. I know no tool already
using those features anyway.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2080743
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux