https://bugzilla.redhat.com/show_bug.cgi?id=2179567 Iñaki Ucar <i.ucar86@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |i.ucar86@xxxxxxxxx --- Comment #5 from Iñaki Ucar <i.ucar86@xxxxxxxxx> --- One of the R maintainers here. @Benson: I can take it from here if you like. (In reply to Benson Muite from comment #4) > Still get a warning > > - Package have the default element marked as %%doc :DESCRIPTION > > not sure why. We see this in all R packages, it's a false positive. The file list in the spec conforms to the packaging guidelines. > The license file just has copyright information, but not the text of the MIT > license. > Made a pull request with that: > https://github.com/bmewing/gpx/pull/11 The R language provides all the texts, and packages must NOT include new copies. This is CRAN policy and we replicate this policy in Fedora. So this is fine, and you should close that PR, because the file you are trying to modify is ok. See this for more details: https://cran.r-project.org/doc/manuals/r-release/R-exts.html#Licensing > Fedora-review gives the following errors: > > R-gpx.noarch: W: only-non-binary-in-usr-lib > R-gpx.noarch: E: noarch-with-lib64 > > Should some exceptions be made for R packages? In this case: > usr/lib64/R/library/gpx/R/gpx.rdb > usr/lib64/R/library/gpx/R/gpx.rdx > > rdx and rdb files are in other R packages. > > https://fedoraproject.org/wiki/Common_Rpmlint_issues The issue here is this line: %global rlibdir %{_libdir}/R/library It should be _datadir instead of _libdir for a noarch package. More comments: - The URL and Source0 fields do not conform to the packaging guidelines. Please, fix this. See the sample spec: https://docs.fedoraproject.org/en-US/packaging-guidelines/R/#_spec_templates_for_r_packages - The Requires: R-core is not needed, please remove it (see again the sample spec; this will give a warning in the package review tool, but that's fine, it's a false positive). - The Summary should be the description on CRAN, i.e.: "Process GPX Files into R Data Structures". - The Description should be just the long description on CRAN, i.e.: "Process open standard GPX files into data.frames for further use and analysis in R." -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2179567 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
