https://bugzilla.redhat.com/show_bug.cgi?id=2182080 --- Comment #5 from Jerry James <loganjerry@xxxxxxxxx> --- I don't know, Miro. I think I was already in debt to you, so this is going to push me in deeper. :-) For this review: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues ====== - The output from licensecheck shows files with other licenses. These are the ones I see being compiled in the build log: BSD-3-Clause: modules/random/random.c BSD-4-Clause: lib/bsd/popen.c ISC: modules/base64/base64.c - Nit pick: the URL could be https instead of http. Not a requirement, just pointing it out. - Nit pick: I understand we prefer to use %{build_cflags} and %{build_cxxflags} these days instead of %{optflags}. Also not a requirement. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 2-Clause License", "BSD-4-Clause (University of California-Specific)", "Historical Permission Notice and Disclaimer - sell variant [generated file]", "BSD 3-Clause License", "ISC License", "Kevlin Henney License". 732 files have unknown license. Detailed output of licensecheck in /home/jamesjer/2182080-snobol4/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 215040 bytes in 36 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in snobol4-devel Errrrr ... it's in there. I'm looking at it. Fedora-review bug? [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. However, regression tests are run during the build, so there is probably no point to a separate %check script. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: snobol4-2.3.1-1.fc39.x86_64.rpm snobol4-devel-2.3.1-1.fc39.x86_64.rpm snobol4-debuginfo-2.3.1-1.fc39.x86_64.rpm snobol4-debugsource-2.3.1-1.fc39.x86_64.rpm snobol4-2.3.1-1.fc39.src.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp0wfetq57')] checks: 31, packages: 5 snobol4.spec: W: patch-not-applied Patch1: snobol4-2.3.1-configure-no-opt.patch snobol4-devel.x86_64: W: only-non-binary-in-usr-lib snobol4.x86_64: W: no-manual-page-for-binary sdb-2.3.1 snobol4.x86_64: W: no-manual-page-for-binary snobol4-2.3.1 snobol4.x86_64: W: no-manual-page-for-binary snopea-2.3.1 snobol4-devel.x86_64: W: no-documentation snobol4.src: W: name-repeated-in-summary SNOBOL4 snobol4.x86_64: W: name-repeated-in-summary SNOBOL4 snobol4.spec:47: W: configure-without-libdir-spec ================= 5 packages and 0 specfiles checked; 0 errors, 9 warnings, 0 badness; has taken 0.6 s ================= Rpmlint (debuginfo) ------------------- Checking: snobol4-debuginfo-2.3.1-1.fc39.x86_64.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpan3cs5jk')] checks: 31, packages: 1 ================= 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s ================= Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 4 snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/base64.so retstring_free (/usr/lib64/snobol4/2.3.1/lib/shared/base64.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/digest.so lookup_handle (/usr/lib64/snobol4/2.3.1/lib/shared/digest.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/digest.so retstring (/usr/lib64/snobol4/2.3.1/lib/shared/digest.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/digest.so remove_handle (/usr/lib64/snobol4/2.3.1/lib/shared/digest.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/digest.so nmgetstring (/usr/lib64/snobol4/2.3.1/lib/shared/digest.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/digest.so new_handle2 (/usr/lib64/snobol4/2.3.1/lib/shared/digest.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/dirs.so retstring (/usr/lib64/snobol4/2.3.1/lib/shared/dirs.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/dirs.so new_handle2 (/usr/lib64/snobol4/2.3.1/lib/shared/dirs.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/dirs.so lookup_handle (/usr/lib64/snobol4/2.3.1/lib/shared/dirs.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/dirs.so remove_handle (/usr/lib64/snobol4/2.3.1/lib/shared/dirs.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/dirs.so mgetstring (/usr/lib64/snobol4/2.3.1/lib/shared/dirs.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/fork.so getstring (/usr/lib64/snobol4/2.3.1/lib/shared/fork.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/fork.so retstring (/usr/lib64/snobol4/2.3.1/lib/shared/fork.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/logic.so retstring (/usr/lib64/snobol4/2.3.1/lib/shared/logic.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/ndbm.so getstring (/usr/lib64/snobol4/2.3.1/lib/shared/ndbm.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/ndbm.so retstring (/usr/lib64/snobol4/2.3.1/lib/shared/ndbm.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/ndbm.so new_handle2 (/usr/lib64/snobol4/2.3.1/lib/shared/ndbm.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/ndbm.so lookup_handle (/usr/lib64/snobol4/2.3.1/lib/shared/ndbm.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/ndbm.so remove_handle (/usr/lib64/snobol4/2.3.1/lib/shared/ndbm.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/ndbm.so mgetstring (/usr/lib64/snobol4/2.3.1/lib/shared/ndbm.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/readline.so retstring_free (/usr/lib64/snobol4/2.3.1/lib/shared/readline.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/readline.so mgetstring (/usr/lib64/snobol4/2.3.1/lib/shared/readline.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/sprintf.so getstring (/usr/lib64/snobol4/2.3.1/lib/shared/sprintf.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/sprintf.so retstring (/usr/lib64/snobol4/2.3.1/lib/shared/sprintf.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/sqlite3.so nmgetstring (/usr/lib64/snobol4/2.3.1/lib/shared/sqlite3.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/sqlite3.so retstring (/usr/lib64/snobol4/2.3.1/lib/shared/sqlite3.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/sqlite3.so new_handle2 (/usr/lib64/snobol4/2.3.1/lib/shared/sqlite3.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/sqlite3.so lookup_handle (/usr/lib64/snobol4/2.3.1/lib/shared/sqlite3.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/sqlite3.so remove_handle (/usr/lib64/snobol4/2.3.1/lib/shared/sqlite3.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/sqlite3.so mgetstring (/usr/lib64/snobol4/2.3.1/lib/shared/sqlite3.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/stat.so mgetstring (/usr/lib64/snobol4/2.3.1/lib/shared/stat.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/stcl.so retstring (/usr/lib64/snobol4/2.3.1/lib/shared/stcl.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/stcl.so new_handle2 (/usr/lib64/snobol4/2.3.1/lib/shared/stcl.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/stcl.so lookup_handle (/usr/lib64/snobol4/2.3.1/lib/shared/stcl.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/stcl.so remove_handle (/usr/lib64/snobol4/2.3.1/lib/shared/stcl.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/stcl.so mgetstring (/usr/lib64/snobol4/2.3.1/lib/shared/stcl.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/time.so getstring (/usr/lib64/snobol4/2.3.1/lib/shared/time.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/time.so nmgetstring (/usr/lib64/snobol4/2.3.1/lib/shared/time.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/time.so retstring (/usr/lib64/snobol4/2.3.1/lib/shared/time.so) snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/zlib.so retstring_free (/usr/lib64/snobol4/2.3.1/lib/shared/zlib.so) snobol4-devel.x86_64: W: only-non-binary-in-usr-lib snobol4.x86_64: W: no-manual-page-for-binary sdb-2.3.1 snobol4.x86_64: W: no-manual-page-for-binary snobol4-2.3.1 snobol4.x86_64: W: no-manual-page-for-binary snopea-2.3.1 snobol4-devel.x86_64: W: no-documentation snobol4.x86_64: W: name-repeated-in-summary SNOBOL4 4 packages and 0 specfiles checked; 0 errors, 46 warnings, 0 badness; has taken 2.4 s Unversioned so-files -------------------- snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/base64.so snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/digest.so snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/dirs.so snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/fork.so snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/logic.so snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/ndbm.so snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/random.so snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/readline.so snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/sprintf.so snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/sqlite3.so snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/stat.so snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/stcl.so snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/time.so snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/zlib.so Source checksums ---------------- https://ftp.regressive.org/snobol4/snobol4-2.3.1.tar.gz : CHECKSUM(SHA256) this package : 91244d67d4e29d2aadce5655bd4382ffab44c624a7ea4ad6411427f3abf17535 CHECKSUM(SHA256) upstream package : 91244d67d4e29d2aadce5655bd4382ffab44c624a7ea4ad6411427f3abf17535 Requires -------- snobol4 (rpmlib, GLIBC filtered): /usr/bin/sh glibc libbz2.so.1()(64bit) libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libgdbm_compat.so.4()(64bit) liblzma.so.5()(64bit) liblzma.so.5(XZ_5.0)(64bit) libm.so.6()(64bit) libreadline.so.8()(64bit) libsqlite3.so.0()(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) libtcl8.6.so()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) snobol4-devel (rpmlib, GLIBC filtered): snobol4(x86-64) snobol4-debuginfo (rpmlib, GLIBC filtered): snobol4-debugsource (rpmlib, GLIBC filtered): Provides -------- snobol4: snobol4 snobol4(x86-64) snobol4-devel: snobol4-devel snobol4-devel(x86-64) snobol4-debuginfo: debuginfo(build-id) snobol4-debuginfo snobol4-debuginfo(x86-64) snobol4-debugsource: snobol4-debugsource snobol4-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2182080 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: PHP, SugarActivity, Java, fonts, Ocaml, Python, R, Perl, Haskell, Ruby Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2182080 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
