https://bugzilla.redhat.com/show_bug.cgi?id=2176670 Peter Robinson <pbrobinson@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #2 from Peter Robinson <pbrobinson@xxxxxxxxx> --- This looks mostly fine, just one small piece: install -d %{buildroot}%{_sysconfdir}/ostree/remotes.d/ %dir %{_sysconfdir}/ostree/remotes.d That directory shouldn't need to be created as it's owned/created by the ostree-libs package so we should just add that as a BuildReq so it's there during build, and a Requires. That can be fixed before commit, other than that this is APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2176670 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
