https://bugzilla.redhat.com/show_bug.cgi?id=2173018 --- Comment #4 from Troy Curtis <troy@xxxxxxxxxxxxxxxx> --- I see that you've indicated uncertainty on how to handle the injected JS files from Sphinx itself on https://pagure.io/packaging-committee/pull-request/1244, I definitely had a similar question. On the jquery and underscore bundling, it seems like the guidelines indicate that a version number needs to be included as long as there is one available. In this case the version is definitely available. However, it certainly seems likely to quickly become inaccurate, since the version could change without a new update to this package. Namely, if Sphinx is upgraded and contains a version change of the bundled packages, and this package is rebuilt for any reason (like a mass rebuild for a new Fedora version), then the bundled library would be a different version than what the spec file indicates. Perhaps this is sufficient reason to not include version numbers, since there is no practical way to ensure they are correct over time? To me, it doesn't seem like there is sufficient direction on properly applying current guidelines in these cases. Similar to Ben's approach [1], I ended up opting to not include the doxygen output for a few of my recent packages pending more clarity (which has a related, though possibly even worse situation as Sphinx generated docs). Of course, there are already many, many existing packages with Sphinx generated docs which complicates the application of any newly defined guidelines which might come out. 1: https://lists.fedoraproject.org/archives/list/packaging@xxxxxxxxxxxxxxxxxxxxxxx/message/77PBRFO7OAQJTNCCY5TYIKGGXFLAKZJ4/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2173018 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
