https://bugzilla.redhat.com/show_bug.cgi?id=2163518 Troy Curtis <troy@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(troy@troycurtisjr | |.com) | --- Comment #7 from Troy Curtis <troy@xxxxxxxxxxxxxxxx> --- (In reply to Ondrej Mosnáček from comment #5) > (In reply to Troy Curtis from comment #4) > > Issues > > ====== > > - "%pytest" is preferred to the deprecated "%python3 setup.py test" statement > > %pytest doesn't work for this project because it doesn't use pytest, only > the deprecated setup.py feature. It would need to be migrated to pytest, but > unfortunately I'm not familiar enough with Python tooling to do that :/ Yeah oftentimes, just using pytest as the runner is enough if unittests were used in the past. Mostly it comes down to the naming conventions for test discovery. I think in this case it would have just worked had upstream not put everything into the "__init__.py" file. Oh well, sorry for the distraction, I thought I had actually tried this one out first to make sure it was usable! > > > - If I enable the tests, they all fail. Either due to errors > > (AttributeError: 'NoneType' object has no attribute 'tags') or failures > > (AssertionError: 11 != 13). > > That seems to be due to missing commit d11e92b45907 ("tests: fix download of > the Ogg file"). When I apply it as a patch (with b3df8561f38e as a context > dependency) they pass for me with the current ffmpeg-free (used to require > full ffmpeg from RPMFusion, but thanks to [1] it doesn't anymore). Would you > like me to add those patches to the spec? Yes, it only makes sense to include the conditional test block if enabling it would result in a usable configuration. I suspect as a packager, having the tests functional will be very useful, so I would definitely recommend applying the patch. Since these tests can't be run on koji anyway due to the network requirement, it might be equally valid to remove the test option entirely. It might be nice to try to nudge upstream to roll a new release since it seems like there are a few fixes which have been merged since the last release. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2163518 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
