[Bug 2163447] Review Request: mustach - Tiny Mustach processor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2163447



--- Comment #13 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
$ diff -Naur mustach.spec 20230314/mustach.spec 
--- mustach.spec        2023-03-12 11:21:09.582015084 -0400
+++ 20230314/mustach.spec       2023-03-14 09:53:59.817462697 -0400
@@ -36,7 +36,7 @@
 %package lib-core-devel

 Summary:        Core library of mustach - Development files
-Requires:       %{name}-lib-core = %{version}
+Requires:       %{name}-lib-core%{?_isa} = %{version}

 %description lib-core-devel
 Core development files for mustach core library
@@ -143,7 +143,6 @@
 %files lib-core-devel
 %{_libdir}/libmustach-core.so
 %{pkgdir}/libmustach-core.pc
-%{_includedir}/mustach
 %{_includedir}/mustach/mustach.h
 %{_includedir}/mustach/mustach-wrap.h
 %dir %{_includedir}/mustach

-----

This looks reasonable. It’s still unnecessarily difficult to review the package
when you don’t post an updated source RPM. I used the updated spec file to make
my own source RPM, and I’ll finish re-reviewing shortly.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2163447
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux