https://bugzilla.redhat.com/show_bug.cgi?id=2163518 Ondrej Mosnáček <omosnacek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(omosnacek@gmail.c | |om) | --- Comment #5 from Ondrej Mosnáček <omosnacek@xxxxxxxxx> --- (In reply to Troy Curtis from comment #4) > Issues > ====== > - "%pytest" is preferred to the deprecated "%python3 setup.py test" statement %pytest doesn't work for this project because it doesn't use pytest, only the deprecated setup.py feature. It would need to be migrated to pytest, but unfortunately I'm not familiar enough with Python tooling to do that :/ > - Since this is meant to be used as a CLI app, a basic man page would be very > useful. help2man or using pandoc with markdown would be pretty easy to create > a basic manpage. > https://eddieantonio.ca/blog/2015/12/18/authoring-manpages-in-markdown-with- > pandoc/ Ok, I'll look into adding a manpage. > - If I enable the tests, they all fail. Either due to errors > (AttributeError: 'NoneType' object has no attribute 'tags') or failures > (AssertionError: 11 != 13). That seems to be due to missing commit d11e92b45907 ("tests: fix download of the Ogg file"). When I apply it as a patch (with b3df8561f38e as a context dependency) they pass for me with the current ffmpeg-free (used to require full ffmpeg from RPMFusion, but thanks to [1] it doesn't anymore). Would you like me to add those patches to the spec? [1] https://src.fedoraproject.org/rpms/ffmpeg/c/45f894ec0e43a37775393c159021a4ac60170a55?branch=rawhide -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2163518 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
