https://bugzilla.redhat.com/show_bug.cgi?id=2177305 --- Comment #8 from Kaleb KEITHLEY <kkeithle@xxxxxxxxxx> --- (In reply to Jakub Kadlčík from comment #7) > Thank you for the package Kaleb, > overall it looks good. > > > > Url: https://github.com/civetweb > > I'd change the Url to https://github.com/civetweb/civetweb but that's > a minor thing. > > > > Summary: Civetweb Client Library C and C++ header files > > Group: Development/Libraries > > Requires: %{name}%{?_isa} = %{version}-%{release} > > Nitpick: Inconsistent indenting > > > > %defattr(-,root,root,-) > > I think this is a default and can be deleted > > > > %{_includedir}/* > > %{_libdir}/cmake/* > > Can you make it more specific, please? > > > > Group: Development/Libraries > > According to the packaging guidelines, Group tag shouldn't be used anymore > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections All of the above have been addressed in the new src.rpm (and .spec) at https://kkeithle.fedorapeople.org/civetweb/civetweb-1.15-1.fc39.src.rpm > > [ ]: Package must own all directories that it creates. > > Note: Directories without known owners: /usr/lib/debug/.build-id/8a, > > /usr/lib/debug/.build-id/56, /usr/lib/debug/.build-id/f3 > > Can you please take a look at this one? Those are from the debuginfo build, right? I've never done anything for those in any of the other packages I've added. E.g. last year I packaged liborc and libarrow and didn't do anything to exclude debuginfo in those. If you can tell me what I'm supposed to do I'll do it, otherwise I haven't got a clue. (No help here https://docs.fedoraproject.org/en-US/packaging-guidelines/Debuginfo/ that I can see.) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2177305 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
