[Bug 2177305] Review Request: civetweb - Embedded C/C++ web server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2177305



--- Comment #7 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> ---
Thank you for the package Kaleb,
overall it looks good.


> Url:            https://github.com/civetweb

I'd change the Url to https://github.com/civetweb/civetweb but that's
a minor thing.


> Summary: Civetweb Client Library C and C++ header files
> Group:          Development/Libraries
> Requires:       %{name}%{?_isa} = %{version}-%{release}

Nitpick: Inconsistent indenting


> %defattr(-,root,root,-)

I think this is a default and can be deleted


> %{_includedir}/*
> %{_libdir}/cmake/*

Can you make it more specific, please?


> Group:          Development/Libraries

According to the packaging guidelines, Group tag shouldn't be used anymore
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections


> [ ]: Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/lib/debug/.build-id/8a,
>      /usr/lib/debug/.build-id/56, /usr/lib/debug/.build-id/f3

Can you please take a look at this one?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2177305
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux