https://bugzilla.redhat.com/show_bug.cgi?id=2165381 --- Comment #4 from Charles R. Anderson <cra@xxxxxx> --- Thank you for the review. I have updated the package: Spec URL: https://cra.fedorapeople.org/ancient/ancient.spec SRPM URL: https://cra.fedorapeople.org/ancient/ancient-2.0.0-2.fc37.src.rpm (In reply to Benson Muite from comment #2) > a) There is a test script, but upstream has not included any test data. > Maybe this could be added to the repo? > c) Is it possible to add a smoke test, for example > ancient --help I added a test that verifies ancient decompressing Source0's gzip compression. > b) Assume none of the algorithms are under a patent? I'm not a patent attorney, but I assume so--these are either ancient file formats or formats that are already implemented in other parts of Fedora. Nothing here is called out as explicitly prohibited on https://docs.fedoraproject.org/en-US/packaging-guidelines/what-can-be-packaged/ or the linked documents therein. I'm not sure what else is expected of a packager on this point, especially considering that doing a patent review could actually increase legal exposure. > d) devel package does not need a license file as it will be pulled in from > libs package Removed. (In reply to Ben Beasley from comment #3) > Please don’t glob over a shared directory; see > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists. > %{_bindir}/ancient Done. > > a) There is a test script, but upstream has not included any test data. Maybe this could be added to the repo? > > Considering that this tool is intended for files from the 1980’s-1990’s, I > strongly suspect that the test data is not included because it is all > non-free. Agreed. Hopefully the gzip test I implemented is sufficient. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2165381 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
