https://bugzilla.redhat.com/show_bug.cgi?id=2165381 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |code@xxxxxxxxxxxxxxxxxx --- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Please don’t glob over a shared directory; see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists. You can change %{_bindir}/* to %{_bindir}/ancient in the %files list. ---- > a) There is a test script, but upstream has not included any test data. Maybe this could be added to the repo? Considering that this tool is intended for files from the 1980’s-1990’s, I strongly suspect that the test data is not included because it is all non-free. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2165381 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
