Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request cppad - A Package for Differentiation of C++ Algorithms https://bugzilla.redhat.com/show_bug.cgi?id=416761 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-12-26 13:24 EST ------- For 20071225-1: * Requires: - %_includedir/%name/local/test_vector.hpp contains --------------------------------------------------------------- 101 # if CPPAD_BOOSTVECTOR 102 # include <boost/numeric/ublas/vector.hpp> 103 # define CPPAD_TEST_VECTOR boost::numeric::ublas::vector 104 # endif --------------------------------------------------------------- Does this mean that cppad-devel should have "Requires: boost-devel"? - IMO it is bettar that this package has "Requires: libstdc++-devel". * Timestamps - As this package installs text files only, keeping timestamps on installed files is highly preferred. As "make install" uses install-sh, perhaps the following method works for keeping timestamps. --------------------------------------------------------------- %install rm -rf $RPM_BUILD_ROOT export CPPROG="cp -p" make install DESTDIR=$RPM_BUILD_ROOT --------------------------------------------------------------- * Documents - Please add the following document(s) to %doc in -devel. --------------------------------------------------------------- AUTHORS ChangeLog --------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review