[Bug 2119983] Review Request: c-icap - An implementation of an ICAP server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2119983



--- Comment #56 from Simone Caronni <negativo17@xxxxxxxxx> ---
(In reply to Frank Crawford from comment #54)
> Simone, it currently fails to build, as you left off the line
> 
> > install -d -m 0755 %{buildroot}/run/%{name}/
> 
> Would you please fix and we will see how we go.

Right, because I switched from %ghost to %dir just before pushing the commit.

(In reply to Frank Crawford from comment #55)
> Looked at it all a bit closer and you also probably need to update the
> %files line to
> 
> > %attr(0755,%{name},%{name}) %dir /run/%{name}/
> 
> That will match the actual creation in i-icap.tmpfiles.conf.  It may also
> cause a minor conflict for the actual install, as the permissions may be
> wrong at that point, as the owner will be root:root, not c-icap:c-icap. 
> Hmm, which is a bit tricky.

That's not an issue, as the permissions are set in the RPM file when being
assembled:

$ rpm -qpvl c-icap-0.5.11-9.20230220gitc5f2103.fc37.x86_64.rpm | grep run
drwxr-xr-x    2 c-icap   c-icap                      0 Feb 26 11:09 /run/c-icap

Amended the same commit:

Spec URL: https://slaanesh.fedorapeople.org/c-icap.spec
SRPM URL:
https://slaanesh.fedorapeople.org/c-icap-0.5.11-9.20230220gitc5f2103.fc37.src.rpm

* Fri Feb 24 2023 Simone Caronni <negativo17@xxxxxxxxx> -
0.5.11-9.20230220gitc5f2103
- Update to latest snapshot.
- Adjust tmpfiles creation.

https://github.com/scaronni/c-icap/commit/971969f0b7d9a5a4db48da7d678e0beaedff6273


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux