[Bug 2169277] Review Request: braille-printer-app - Braille printer application

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2169277

Zdenek Dohnal <zdohnal@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(benson_muite@emai
                   |                            |lplus.org)



--- Comment #3 from Zdenek Dohnal <zdohnal@xxxxxxxxxx> ---
Hi Benson,

thank you for checking the output!

(In reply to Benson Muite from comment #2)
> Issues from fedora-review:
> 
> braille-printer-app.x86_64: W: package-with-huge-docs 71%

I've removed several files from documentation dir, since it wasn't worthy of
shipping them separately.

> braille-printer-app.x86_64: E: non-standard-executable-perm
> /usr/lib/cups/backend/cups-brf 700
> braille-printer-app.x86_64: E: non-readable /usr/lib/cups/backend/cups-brf
> 700

This is required by cupsd, which starts the backend (root is in cupsd System
Groups - groups of users which are capable of printing, and due possible
Kerberos setups) and cups-brf itself switches to the user who issued printing,
so it needs root privileges to switch into user. The backend is not meant to be
read, be written to by or executed by other user than root, so the permissions
are OK.

> braille-printer-app.x86_64: E: missing-call-to-setgroups-before-setuid
> /usr/lib/cups/backend/cups-brf

Sent a fix upstream https://github.com/OpenPrinting/braille-printer-app/pull/4

> braille-printer-app.spec:118: W: macro-in-comment %license
> braille-printer-app.x86_64: W: incoherent-version-in-changelog
> 2.0b0^9304787c07-1 ['2.0b0^1b63bd1af1-1.fc39', '2.0b0^1b63bd1af1-1']

Fixed in spec file.

New versions are uploaded to previous locations on fedorapeople.org.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2169277
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux