https://bugzilla.redhat.com/show_bug.cgi?id=2168929 --- Comment #2 from Dmitry Belyavskiy <dbelyavs@xxxxxxxxxx> --- https://dbelyavs.fedorapeople.org/liboqs-0.7.2-1.fc36.src.rpm is updated srpm https://dbelyavs.fedorapeople.org/liboqs.spec is updated spec (In reply to Daiki Ueno from comment #1) > Notable issues: > > - Afaik -devel package shouldn't contain *.so.2 (but .so only) Not sure but it can be done if you insist > - %changelog is empty; either opt-in to rpmautospec or add a proper > changelog entry, see: > https://docs.pagure.org/Fedora-Infra.rpmautospec/opting-in.html Done > - Multiple licenses are found; express them in "License:" with "AND" or add > justfication Done > - Install license files from upstream release with %license Done > - Good to run tests in %check > - "Patch01:" doesn't have justification comment; I would also omit the "01" > suffix if %autosetup or %autopatch is used Done > - "Source:" should comply with the guideline, so spectool -g works: > https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ Done > - Package doesn't build in the current rawhide (with "unsupported > instruction `vpcmpeqd'), but in F37 I disabled AVX512 to avoid this error. These options to be tuned later -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2168929 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
