https://bugzilla.redhat.com/show_bug.cgi?id=2154918 --- Comment #2 from Johan Vromans <jvromans@xxxxxxxxxxx> --- Thanks for the feedback. New spec and srpm at: Spec URL: https://www.squirrel.nl/pub/xfer/perl-Text-QRCode.spec SRPM URL: https://www.squirrel.nl/pub/xfer/perl-Text-QRCode-0.05-2.fc37.src.rpm (In reply to Petr Pisar from comment #1) > FIX: Remove a "Text::QRCode -" prefix from the summary. Done. > TODO: Remove "This module requies libqrencode '2.0.0' and above." sentence > from the description. Done. > FIX: Convert a License tag to SPDX format. Fedora moved a license syntax to > SPDX Done. > FIX: Remove "Requires: perl(:MODULE_COMPAT_..." line from the spec file. Done. > FIX: Either unbundle modules found in ./inc ("rm -r ./inc/*" in %prep) and > build-require the few inc::Module::Install modules Done. > FIX: Build-require 'gcc' and 'perl-devel' for building XS modules. > FIX: Build-require 'perl(File::Copy)' (Makefile.PL:4). > FIX: Build-require 'pkgconf-pkg-config' (Makefile.PL:31). > FIX: Build-require 'pkgconfig(libqrencode)' (Makefile.PL:44). > FIX: Build-require 'perl(base)' (lib/Text/QRCode.pm:5). > FIX: Build-require 'perl(vars)' (lib/Text/QRCode.pm:6). > FIX: Build-require 'perl(XSLoader)' (lib/Text/QRCode.pm:15). Done. > Do not build-require 'perl(parent)', 'perl(utf8)'. Done. > FIX: Explicitly list packaged manual pages and %{perl_vendorarch}/auto files Done. > FIX: Package also /usr/lib64/perl5/vendor_perl/Text directory. I'm not sure I understand. If I add %{perl_vendorarch}/Text to %files I get a rpm build warning that %{perl_vendorarch}/Text/QRCode.pm is listed twice. Using %dir %{perl_vendorarch}/Text is not correct since this module does not own this directory. > FIX: Do not require perl(:MODULE_COMPAT_...) explicitly. > FIX: Require 'perl(XSLoader)' (lib/Text/QRCode.pm:15). Already done. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2154918 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
