https://bugzilla.redhat.com/show_bug.cgi?id=2154918 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |perl-Text-QRCode - perl |perl-Text-QRCode - Generate |bindings for libqrencode |text base QR Code --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source0 archive (SHA-512: 2941d15da53dbbe7be6ebf691d08e78146835acc7891dd2d45bbdf6678a6d824044e359d34fde8c7fe1c2ba0eb10feaae4f1162ecc71f821cd2ead19f9bd4085) is original. Ok. FIX: Remove a "Text::QRCode -" prefix from the summary. We do not repeat the module name in RPM summary. Compare to other Perl packages. Also a summary of this review bug must match "%{name} - %{summary}" value from the spec file. TODO: Remove "This module requies libqrencode '2.0.0' and above." sentence from the description. This information is not helpful to users. The dependency is already stated and assured with RPM dependencies. License verified from README, ppport.h, lib/Text/QRCode.pm, inc/Module/Install.pm. Ok. FIX: Convert a License tag to SPDX format. Fedora moved a license syntax to SPDX <https://docs.fedoraproject.org/en-US/legal/license-field/#_perl_packages>. FIX: Remove "Requires: perl(:MODULE_COMPAT_..." line from the spec file. The dependency is now automatically generated with perl-generators. FIX: Either unbundle modules found in ./inc ("rm -r ./inc/*" in %prep) and build-require the few inc::Module::Install modules (Makefile.PL:3), or list all dependencies of ./inc code (e.g. perl(Config) at inc/Module/Install/Can.pm:5). I recommend you the first option as it is much easier and Fedora-way. You can use 'tangerine' tool for enumerating Perl dependencies. FIX: Build-require 'gcc' and 'perl-devel' for building XS modules. FIX: Build-require 'perl(File::Copy)' (Makefile.PL:4). FIX: Build-require 'pkgconf-pkg-config' (Makefile.PL:31). FIX: Build-require 'pkgconfig(libqrencode)' (Makefile.PL:44). FIX: Build-require 'perl(base)' (lib/Text/QRCode.pm:5). FIX: Build-require 'perl(vars)' (lib/Text/QRCode.pm:6). FIX: Build-require 'perl(XSLoader)' (lib/Text/QRCode.pm:15). Do not build-require 'perl(parent)', 'perl(utf8)'. I can see where they are used. FIX: Explicitly list packaged manual pages and %{perl_vendorarch}/auto files <https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists>. All tests pass. Ok. $ rpmlint perl-Text-QRCode.spec ../SRPMS/perl-Text-QRCode-0.05-1.fc38.src.rpm ../RPMS/x86_64/perl-Text-QRCode-* ======================================== rpmlint session starts ======================================= rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 5 ========= 4 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.3 s ======== rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-Text-QRCode-0.05-1.fc38.x86_64.rpm drwxr-xr-x 2 root root 0 Dec 19 01:00 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Dec 19 01:00 /usr/lib/.build-id/bf lrwxrwxrwx 1 root root 66 Dec 19 01:00 /usr/lib/.build-id/bf/295d08b666a3d82947c1fdb4b9459e9ff93cb0 -> ../../../../usr/lib64/perl5/vendor_perl/auto/Text/QRCode/QRCode.so -rw-r--r-- 1 root root 2850 Oct 12 2016 /usr/lib64/perl5/vendor_perl/Text/QRCode.pm drwxr-xr-x 2 root root 0 Dec 19 01:00 /usr/lib64/perl5/vendor_perl/auto/Text drwxr-xr-x 2 root root 0 Dec 19 01:00 /usr/lib64/perl5/vendor_perl/auto/Text/QRCode -rwxr-xr-x 1 root root 15872 Dec 19 01:00 /usr/lib64/perl5/vendor_perl/auto/Text/QRCode/QRCode.so drwxr-xr-x 2 root root 0 Dec 19 01:00 /usr/share/doc/perl-Text-QRCode -rw-r--r-- 1 root root 828 Oct 12 2016 /usr/share/doc/perl-Text-QRCode/Changes -rw-r--r-- 1 root root 1396 Oct 12 2016 /usr/share/doc/perl-Text-QRCode/README -rw-r--r-- 1 root root 1690 Dec 19 01:00 /usr/share/man/man3/Text::QRCode.3pm.gz FIX: Package also /usr/lib64/perl5/vendor_perl/Text directory. $ rpm -q --requires -p ../RPMS/x86_64/perl-Text-QRCode-0.05-1.fc38.x86_64.rpm | sort -f | uniq -c 1 ld-linux-x86-64.so.2()(64bit) 1 ld-linux-x86-64.so.2(GLIBC_2.3)(64bit) 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libperl.so.5.36()(64bit) 1 libqrencode.so.4()(64bit) 2 perl(:MODULE_COMPAT_5.36.0) 1 perl(base) 1 perl(Carp) 1 perl(Exporter) 1 perl(strict) 1 perl(vars) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 rtld(GNU_HASH) FIX: Do not require perl(:MODULE_COMPAT_...) explicitly. FIX: Require 'perl(XSLoader)' (lib/Text/QRCode.pm:15). $ rpm -q --provides -p ../RPMS/x86_64/perl-Text-QRCode-0.05-1.fc38.x86_64.rpm | sort -f | uniq -c 1 perl(Text::QRCode) = 0.05 1 perl-Text-QRCode = 0.05-1.fc38 1 perl-Text-QRCode(x86-64) = 0.05-1.fc38 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-Text-QRCode-0.05-1.fc38.x86_64.rpm Binary dependencies are resolvable. Ok. The package builds in F38 (https://koji.fedoraproject.org/koji/taskinfo?taskID=97051151). Ok. Please correct all 'FIX' items, consider fixing the 'TODO' item, and provide a new spec file. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2154918 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
