https://bugzilla.redhat.com/show_bug.cgi?id=2161525 --- Comment #6 from Lumír Balhar <lbalhar@xxxxxxxxxx> --- (In reply to Miro Hrončok from comment #5) > Before the deps are available in rawhide, I've looked at the spec only. > > > This is used 3 times in the spec file: 4.0.0%{prerel} > > Maybe you might want to define a macro for it. But it's probably fine as it > is :/ I suspect that once this goes out of pre-releases, this will be > replaced simply with %{version} forever. It will, yes. > > > BuildRequires: nodejs > > BuildRequires: npm > > This makes me ask: Are there no bundled javascript libraries in this package? I don't think so. None of the js files look like a bundled library to me. > > > pytest-tornasync will never be available in Fedora > > Why never? If the comment said "is not available" I would be less curious :D Upstream is dead and pytest-jupyter contains some parts of tornasync now. > > > upstream will switch to pytest-jupyter soon > > Any links for this that could be added to the spec? Link added. > > > %config(noreplace) %{_sysconfdir}/jupyter/jupyter_notebook_config.d/jupyterlab.json > > %config(noreplace) %{_sysconfdir}/jupyter/jupyter_server_config.d/jupyterlab.json > > Please add Requires: python-jupyter-filesystem Fixed. Spec URL: https://lbalhar.fedorapeople.org/python-jupyterlab.spec SRPM URL: https://lbalhar.fedorapeople.org/python-jupyterlab-4.0.0~a33-1.fc37.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2161525 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
