[Bug 2161525] Review Request: python-jupyterlab - JupyterLab computational environment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2161525



--- Comment #5 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
Before the deps are available in rawhide, I've looked at the spec only.




This is used 3 times in the spec file: 4.0.0%{prerel}

Maybe you might want to define a macro for it. But it's probably fine as it is
:/ I suspect that once this goes out of pre-releases, this will be replaced
simply with %{version} forever.



> BuildRequires:  nodejs
> BuildRequires:  npm

This makes me ask: Are there no bundled javascript libraries in this package?



> pytest-tornasync will never be available in Fedora

Why never? If the comment said "is not available" I would be less curious :D



> upstream will switch to pytest-jupyter soon

Any links for this that could be added to the spec?



> %config(noreplace) %{_sysconfdir}/jupyter/jupyter_notebook_config.d/jupyterlab.json
> %config(noreplace) %{_sysconfdir}/jupyter/jupyter_server_config.d/jupyterlab.json

Please add Requires: python-jupyter-filesystem


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2161525
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux