https://bugzilla.redhat.com/show_bug.cgi?id=2161558 Michal Josef Spacek <mspacek@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(psalaba@xxxxxxxxx | |m) --- Comment #10 from Michal Josef Spacek <mspacek@xxxxxxxxxx> --- @psalaba@xxxxxxxxxx 1) License is bad: In LICENSE file: The MIT (X11) License In spec file: License: GPL-1.0-or-later OR Artistic-1.0-Perl 2) No .rpmlintrc with warnings: perl-Alien-Brotli-tests.noarch: W: no-documentation 3) BuildRequires: findutils, make, bc I don't see usage of this packages. As i understand, make, bc is used in case of compiling, but not in our case 4) spec file rpmlint: perl-Alien-Brotli.spec:52: W: comparison-operator-in-deptoken 2>/dev/null) perl-Alien-Brotli.spec:53: W: comparison-operator-in-deptoken 2>/dev/null) There is brotli %(perl -e 'print qq{ = $1} if qx{brotli --version} =~ m{([\d+\.]+)}' 2>/dev/null) Why we need this 2>/dev/null ? If we need, then we need to add to .rpmlintrc -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2161558 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
