https://bugzilla.redhat.com/show_bug.cgi?id=2160771 --- Comment #5 from Yaakov Selkowitz <yselkowi@xxxxxxxxxx> --- (In reply to Neal Gompa from comment #4) > Initial spec review: > > > Source0: %{url}/archive/%{commit}/Flatseal-%{commit}.tar.gz > > This has tags, so use those instead: > "%{url}/archive/v%{version}/Flatseal-%{version}.tar.gz" The packaging guidelines say otherwise, since git tags are not immutable: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags > > desktop-file-validate %{buildroot}%{_datadir}/applications/%{app_id}.desktop > > > > appstream-util validate-relax --nonet %{buildroot}%{_datadir}/appdata/%{app_id}.appdata.xml > > These should go into %check for clarity. The guidelines allow either: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2160771 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
