https://bugzilla.redhat.com/show_bug.cgi?id=2160771 Neal Gompa <ngompa13@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags|needinfo?(ngompa13@xxxxxxxx | |m) | --- Comment #4 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial spec review: > Source0: %{url}/archive/%{commit}/Flatseal-%{commit}.tar.gz This has tags, so use those instead: "%{url}/archive/v%{version}/Flatseal-%{version}.tar.gz" > desktop-file-validate %{buildroot}%{_datadir}/applications/%{app_id}.desktop > > appstream-util validate-relax --nonet %{buildroot}%{_datadir}/appdata/%{app_id}.appdata.xml These should go into %check for clarity. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2160771 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
