https://bugzilla.redhat.com/show_bug.cgi?id=2121870 --- Comment #5 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Further comments: a) Can you add -fpie to compile flags and -pie to linker flags $ rpmlint -e position-independent-executable-suggested position-independent-executable-suggested: This executable should be position independent (all binaries should). Check that it is built with -fPIE/-fpie in compiler flags and -pie in linker flags. b) Perhaps use a different version number: $ rpmlint -e invalid-version invalid-version: The version string must not contain the pre, alpha, beta or rc suffixes because when the final version will be out, you will have to use an Epoch tag to make the package upgradable. Instead put it in the release tag, prefixed with something you have control over. c) Maybe add a patch to use getaddrinfo? Initial attempt at: https://gitlab.com/tsocks/tsocks $ rpmlint -e binary-or-shlib-calls-gethostbyname binary-or-shlib-calls-gethostbyname: The binary calls gethostbyname. Please port the code to use getaddrinfo. d) There are further warnings and errors for the debuginfo package, but maybe the ones in the main package should be fixed first. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121870 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
