https://bugzilla.redhat.com/show_bug.cgi?id=2139014 --- Comment #3 from Davide Cavalca <davide@xxxxxxxxxxxx> --- > a) Some of the source code seems to be taken from other places: > https://github.com/wuyongzheng/gimgtools/blob/master/sf_lbl.c > Not sure how extensive this is. Might this affect licensing? Looks like that comes from libgarmin, which is also GPLv2, so I think we're in the clear. I also did a pass with licensechecker and didn't see anything odd there. > b) Is it possible to add smoke tests to check basic functionality? Not really, as exercising this would require having some map data available. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2139014 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue