https://bugzilla.redhat.com/show_bug.cgi?id=2025124 --- Comment #19 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- Thank you for the feedback, I am learning some new tricks :-) I made almost all the requested changes, please take a look. Spec URL: https://download.copr.fedorainfracloud.org/results/frostyx/qtile/fedora-rawhide-x86_64/05193780-qtile/qtile.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/frostyx/qtile/fedora-rawhide-x86_64/05193780-qtile/qtile-0.22.1-4.fc38.src.rpm Diff: https://github.com/frostyx/rpmbuild-topdir/commit/9cec169 There were two problems though. 1. When I started removing the explicit BuildRequires, tests started falling. Do you think, we are installing the generated dependencies incorrectly? Also, just for the record, I am fine with having explicit BuildRequires :-) 2. Wayland support requires much more work than I can allocate to it right now. There are the missing dependencies, and also tests started failing for some reason. I would like to keep the Wayland-specific changes in a WIP state and iteratively fix them one by one. > Not a correction but just a curiosity on my part, what changes when > enabling Wayland support to switch the package from noarch to being > architecture specific? I am curious about this as well. Builds started failing with a message, that I use `BuildArch: noarch` for an architecture-specific package. So I added the condition to fix the issue, but I don't quite understand why it started building architecture-specific RPMs. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2025124 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
