https://bugzilla.redhat.com/show_bug.cgi?id=2025124 --- Comment #18 from Carl George 🤠 <carl@xxxxxxxxxx> --- Another thing I found in the upstream docs was that only the x11 backend is tested by default. To test both we'll need to pass some additional flags to pytest, and we can make the wayland one conditional. -%pytest test +%pytest --backend x11 %{?with_wayland:--backend wayland} https://docs.qtile.org/en/latest/manual/hacking.html#backends ================================================================================ Similarly we can pull in the "wayland" extras requirements and not have to specify them manually. -%if %{with wayland} -# These packages are not in Fedora yet, however they are packaged in Copr -# https://copr.fedorainfracloud.org/coprs/frostyx/qtile/ -# So let's temporarily build the official Fedora package without Wayland support -# but build the Copr package with Wayland support. -BuildRequires: python3-pywlroots -BuildRequires: python3-pywayland -BuildRequires: python3-xkbcommon -%endif -%pyproject_buildrequires +%pyproject_buildrequires %{?with_wayland:-x wayland} That covers the buildrequires for those, but not the runtime requires. For that I think the best approach may be to create some subpackages. * split the libqtile Python library into a python3-libqtile subpackage * use %pyproject_extras_subpkg to generate a python3-libqtile+wayland subpackage * recommend python3-libqtile+wayland from the main qtile package https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#Extras https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#pyproject_extras_subpkg This might be getting a bit too complex for bugzilla comments. Let me know if you'd prefer I just send a PR to your spec file on GitHub. ================================================================================ I sent a PR upstream to split out the "test" and "lint" dependencies. If that looks good to you we can include it as a patch and then install the test dependencies with %pyproject_buildrequires. https://github.com/qtile/qtile/pull/4084 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2025124 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
