https://bugzilla.redhat.com/show_bug.cgi?id=2156237 --- Comment #3 from Troy Curtis <troy@xxxxxxxxxxxxxxxx> --- (In reply to Benson Muite from comment #2) > > Comments: > a) Might it be possible to do a smoke test? Perhaps compile and run the > provided example? The example is pretty useless, even as a smoketest IMO, however I figured out that the fuzzers test multiple APIs using clang's fuzzer capabilities. So I've enabled the fuzzers and run a simple loop on the resulting executables. Since this is a header only library anyway, there is no impact/change to the runtime package. > b) Perhaps the provided example could also be packaged in the documentation? I ended up building the doxygen html docs and including those. The example isn't particularly meaningful. > c) May also package changelog in the documentation Good idea! Included. > d) It would be helpful to indicate filetypes that are installed, so perhaps > use > %{_includedir}/rapidfuzz/*.hpp > %{_includedir}/rapidfuzz/*.impl > %{_includedir}/rapidfuzz/distance/*.hpp > %{_includedir}/rapidfuzz/details/*.hpp > %{_libdir}/cmake/rapidfuzz/*.cmake This seems unusual and a bit redundant. This package owns the directories (and must own them), and including the directory automatically pulls in the contained files. Some workarounds would have to be employed to own the dir, but not include the files, and then manually include the files contained by the directory (using the %dir macro presumably, though I haven't actually tested it). All to basically communicate that "header files are included from the include path and cmake files are included from the cmake path". Since these aren't shared directories, and there isn't a SOVERSION unexpected bump type of situation, I don't think using the multiple globs improves the specfile in this case. > e) need dist in the spec file > Release: 1%{?dist} This spec file is using the rpmautospec tooling, %autorelease takes care of this automatically (even though fedora-review hasn't been "taught" about it yet). This can be confirmed from the srpm itself: ❯ rpm -q --info --changelog ./rapidfuzz-cpp-1.10.4-3.fc38.src.rpm Name : rapidfuzz-cpp Version : 1.10.4 Release : 3.fc38 Architecture: x86_64 Install Date: (not installed) Group : Unspecified Size : 287061 License : MIT Signature : (none) Source RPM : (none) Build Date : Sat 31 Dec 2022 10:47:49 AM EST Build Host : arafel URL : https://github.com/maxbachmann/rapidfuzz-cpp Summary : A fast string matching header-only library for C++ Description : RapidFuzz is a fast string matching library for Python and C++, which is using the string similarity calculations from FuzzyWuzzy. However there are two aspects that set RapidFuzz apart from FuzzyWuzzy: 1. It is MIT licensed so it can be used whichever License you might want to choose for your project, while you're forced to adopt the GPL license when using FuzzyWuzzy 2. It is mostly written in C++ and on top of this comes with a lot of Algorithmic improvements to make string matching even faster, while still providing the same results. This is the C++ component of RapidFuzz, the Python library is available in the python-rapidfuzz package. * Sat Dec 31 2022 Troy Curtis Jr <troy@xxxxxxxxxxxxxxxx> - 1.10.4-3 - Add doxygen API docs and CHANGELOG as documentation. * Sat Dec 31 2022 Troy Curtis Jr <troy@xxxxxxxxxxxxxxxx> - 1.10.4-2 - Use clang to build the fuzzers to use as a package test. * Sun Dec 25 2022 Troy Curtis Jr <troy@xxxxxxxxxxxxxxxx> - 1.10.4-1 - Initial spec file. Updated spec and srpm available at: https://troycurtisjr.fedorapeople.org/rapidfuzz-cpp/rapidfuzz-cpp.spec https://troycurtisjr.fedorapeople.org/rapidfuzz-cpp/rapidfuzz-cpp-1.10.4-3.fc38.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2156237 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
