https://bugzilla.redhat.com/show_bug.cgi?id=2156234 --- Comment #8 from Troy Curtis <troy@xxxxxxxxxxxxxxxx> --- (In reply to Benson Muite from comment #7) > Thanks. Output of Fedora-Review: > https://download.copr.fedorainfracloud.org/results/fed500/taskflow/fedora- > rawhide-x86_64/05192764-taskflow/fedora-review/review.txt > > a) Can you add > Release: 1%{?dist} This spec file is using the rpmautospec[1] macros, %autorelease & %autochangelog. The release and dist tag are automatically created during the build. These are actually present in their expanded form in the srpm. This can be verified by inspecting the srpm directly: ❯ rpm -q --info ./taskflow-3.4.0-4.fc38.src.rpm Name : taskflow Version : 3.4.0 Release : 4.fc38 <-- Note the release and dist. 4 since this is now my fourth iteration in this review. I plan to squash down to the single first commit on import. ❯ rpm -q --changelog ./taskflow-3.4.0-4.fc38.src.rpm * Sat Dec 31 2022 Troy Curtis Jr <troy@xxxxxxxxxxxxxxxx> - 3.4.0-4 - Remove intermediate xml files from the docs. * Fri Dec 30 2022 Troy Curtis Jr <troy@xxxxxxxxxxxxxxxx> - 3.4.0-3 - Add a doc subpackage and remove ref PDFs due to licensing. * Fri Dec 30 2022 Troy Curtis Jr <troy@xxxxxxxxxxxxxxxx> - 3.4.0-2 - Remove bundled 3rd party libraries. * Sun Dec 25 2022 Troy Curtis Jr <troy@xxxxxxxxxxxxxxxx> - 3.4.0-1 - Initial spec file. It is one of the known limitations of the fedora-review tool that it doesn't "know" about those quite yet, but luckily it replaces a manual process with an automated one, so the presence of %autorelease indicates that it will Do The Right Thing during the build. > to the spec file? > b) Might it be possible to use softlinks for some of the duplicated files in > the documentation? I did one better, I removed them, along with everything under xml/. When looking as to why they are duplicated, I realized that the files in the xml/ directory are actually just intermediate files on the way to generate the html docs. Thus the xml directory doesn't need to be there at all (and probably shouldn't have been in the source tarball to begin with). Updated spec and srpm: https://troycurtisjr.fedorapeople.org/taskflow/taskflow.spec https://troycurtisjr.fedorapeople.org/taskflow/taskflow-3.4.0-4.fc38.src.rpm 1: https://docs.pagure.org/Fedora-Infra.rpmautospec/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2156234 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
