https://bugzilla.redhat.com/show_bug.cgi?id=2126785 Björn Persson <bjorn@xxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(bjorn@xn--rombobj | |rn-67a.se) | --- Comment #18 from Björn Persson <bjorn@xxxxxxxxxxxxxxxxxxxx> --- I haven't forgotten this but several other things took priority. At last I've had some time for review work again. Points 2, 5, 7, 12, 16 and 26 are fixed. Points 21 and 29 are unanswered but not blocking. These aren't yet fully resolved: 25: The -mqtt subpackage is now arch-independent, as I requested. Thus it can of course not have arch-specific dependencies. Remove "%{_isa}" from its Requires tags. 27: No change since the previous version. Why do you run pyproject_buildrequires in %prep instead of in %generate_buildrequires? What do you expect it to accomplish when run in %prep? 28: The group is now created properly thanks to the groupadd command. sysusers_create_compat still does nothing, so RPMlint still warns "empty-%pre". This won't cause any technical problems, but it will cause confusion as people reading the spec will think sysusers_create_compat is supposed to do something. It should therefore be removed. As "force" is a rather unintuitive parameter name, I think it's wise to include an explanation under the groupadd command, as I wrote above: "# --force means it's not an error if the group already exists." That's just my opinion though, not review-blocking. Two new issues have appeared: 30: Why did you remove systemd_postun_with_restart? Should the running daemon not be replaced with the new version on upgrade? 31: RPMlint now thinks the summary is too long: usbrelay.x86_64: E: summary-too-long A library and command line tool for controlling USB-connected relays based on hidapi The policy says only that the summary shall be short and concise. According to "rpmlint --explain summary-too-long" the limit is 80 characters. Maybe the information that HIDAPI is used can be moved to the description where there is more room? Another way to shave off a few letters would be to write "to control" instead of "for controlling". -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2126785 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
