https://bugzilla.redhat.com/show_bug.cgi?id=2149999 --- Comment #2 from Zamir SUN <sztsian@xxxxxxxxx> --- (In reply to Sandro Mani from comment #1) > Taking, initial comments: > > - Appears to depend on lxqt-build-tools = 0.12.0, but current version in > Fedora is lxqt-build-tools-0.11.0. Well yes. lxqt-build-tools-0.12.0 is part of LXQt 1.2.0. I don't feel like doing partial update to avoid FTBFS errors so it became a chicken-and-egg issue for review. > - Reason for %define __cmake_in_source_build 1? > - Suggestion to use %cmake_build and %cmake_install (and possibly %autosetup > -p1): Thanks for the suggestions. Just removed the in-source build macro and it works fine. SPEC: https://download.copr.fedorainfracloud.org/results/zsun/review-lxqt/fedora-rawhide-x86_64/05148442-qtxdg-tools/qtxdg-tools.spec SRPM: https://download.copr.fedorainfracloud.org/results/zsun/review-lxqt/fedora-rawhide-x86_64/05148442-qtxdg-tools/qtxdg-tools-3.10.0-1.fc38.src.rpm fedora-review: https://download.copr.fedorainfracloud.org/results/zsun/review-lxqt/fedora-rawhide-x86_64/05148442-qtxdg-tools/fedora-review/review.txt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2149999 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
