[Bug 2149999] Review Request: qtxdg-tools - User tools for libqtxdg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2149999

Sandro Mani <manisandro@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |manisandro@xxxxxxxxx
             Status|NEW                         |ASSIGNED
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |manisandro@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Sandro Mani <manisandro@xxxxxxxxx> ---
Taking, initial comments:

- Appears to depend on lxqt-build-tools = 0.12.0, but current version in Fedora
is lxqt-build-tools-0.11.0.
- Reason for %define __cmake_in_source_build 1?
- Suggestion to use %cmake_build and %cmake_install (and possibly %autosetup
-p1):

    %prep
    %autosetup -p1

    %build
    %{cmake_lxqt} -DBUNDLE_XDG_UTILS=NO -DPULL_TRANSLATIONS=NO ..
    %cmake_build

    %install
    %cmake_install

Rest looks good.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2149999
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux