https://bugzilla.redhat.com/show_bug.cgi?id=2151458 --- Comment #5 from Akira TAGOH <tagoh@xxxxxxxxxx> --- Thank you for reviewing. > Comments: > a) When importing can you change the line ending encoding in Readme_ipaexg00401.txt for example using dos2unix Readme_ipaexg00401.txt > this would add dos2unix as a dependency. Sure. will do. > Minor points/questions: > i) In the ttf file, the font foundry has an extra space > foundry: "IPA "(s) Well, that's intentional thing. the foundry property is coming from achVendID in OS2 table which is supposed to be 4-character string and stores as it is. https://learn.microsoft.com/en-us/typography/opentype/spec/os2#achvendid ii) Maybe users might appreciate Japanese names in 68-ipa-exgothic-fonts.conf I could add it as well. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2151458 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
