https://bugzilla.redhat.com/show_bug.cgi?id=2119494 --- Comment #70 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Thanks. Great on getting your patches upstream. The libraries: libA4GL_HTML.so()(64bit) libA4GL_file.so()(64bit) libA4GL_memcache.so()(64bit) libA4GL_pick.so()(64bit) libA4GL_roman.so()(64bit) libA4GL_string.so()(64bit) libDATA_module.so()(64bit) libDATA_module_definition.so()(64bit) libDATA_report.so()(64bit) libDATA_struct_form.so()(64bit) libEXREPORT_NOPDF.so()(64bit) libFORM_GENERIC.so()(64bit) libFORM_NOFORM.so()(64bit) libHELP_std.so()(64bit) libLEX_C.so()(64bit) libLEX_EC.so()(64bit) libLEX_WRITE.so()(64bit) libLOGREPPROC_CSV.so()(64bit) libLOGREPPROC_HTML.so()(64bit) libLOGREPPROC_TXT.so()(64bit) libMSG_NATIVE.so()(64bit) libPACKER_FORMXML.so()(64bit) libPACKER_MEMPACKED.so()(64bit) libPACKER_PACKED.so()(64bit) libPACKER_PERL.so()(64bit) libPACKER_XML.so()(64bit) libRPC_NORPC.so()(64bit) libSQLPARSE_INFORMIX.so()(64bit) libSQLPARSE_NONE.so()(64bit) libSQL_FILESCHEMA.so()(64bit) libSQL_nosql.so()(64bit) libSQL_pg.so()(64bit) libSQL_pg8.so()(64bit) libUI_CONSOLE.so()(64bit) libUI_HL_TUI.so()(64bit) libUI_HL_TUIN.so()(64bit) libUI_TUI.so()(64bit) libUI_TUI_wide.so()(64bit) libUI_XML.so()(64bit) libbarcode.so()(64bit) libchannel.so()(64bit) liberrhook_sample.so()(64bit) Should not be in provides unless they have sonames. Expect they should likely be private libraries. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shared_libraries Globbbing an entire directory: %{_libdir}/%{name}/etc/* %{_libdir}/%{name}/tools/* makes it unclear what is packaged. Can a list files or pattern matching based on file extensions be used? For example: %{_libdir}/%{name}/etc/aubitrc %doc tools/examples/comments/*.4gl %doc tools/examples/embedded_c/*.4gl %doc tools/examples/file/*.4gl %doc tools/examples/general/*.4gl %doc tools/examples/key_handling/*.4gl %doc tools/examples/logical_reports/*.4gl The examples are also documentation, so should not go into the library directory. Any reason not to package fdecompile, unmkmessage given that fcompile and amkmessage are packaged and so these other two would be useful for developers using aubit4gl? This is not a blocker, but curious why you choose not to package them. Since man pages are provided, it seems ok not to package the pdf manuals. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2119494 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
