https://bugzilla.redhat.com/show_bug.cgi?id=2150574 --- Comment #6 from Orion Poplawski <orion@xxxxxxxx> --- (In reply to Miro Hrončok from comment #5) > # THe deslected tests seem to require some kind of package server > > Typo THe. > Typo deselected. Fixed > Question out of curiosity (not a blocker for the package review): > In %check, you set CONDA_EXE to %{_bindir}/conda. What is the default value? Well, /etc/profile.d/conda.sh from the conda package sets it to /usr/bin/conda, but that doesn't get sourced in the package build. I suppose I could do: . /etc/profile.d/conda.sh instead. Done. > Also, I see upstream has a [test] extra that can be buildrequired with: > > %pyproject_buildrequires -x test > > Instead of > > # For tests > BuildRequires: python%{python3_pkgversion}-boto3 > BuildRequires: python%{python3_pkgversion}-bottle > BuildRequires: python%{python3_pkgversion}-pytest > BuildRequires: python%{python3_pkgversion}-pytest-mock > > > However, it does not include conda. Should this require conda for tests in > upstream? Ah, thanks - still getting used to the pyproject stuff. It also adds a dep for: python3dist(boto3-stubs) is needed by python-conda-package-streaming-0.7.0-2.fc38.noarch python3dist(boto3-stubs[essential]) is needed by python-conda-package-streaming-0.7.0-2.fc38.noarch which doesn't appear to be strictly necessary and isn't packaged, so I've removed that. As, for conda, yeah upstream probably should. I've filed: https://github.com/conda/conda-package-streaming/pull/52 * Thu Dec 08 2022 Orion Poplawski <orion@xxxxxxxx> - 0.7.0-3 - Use test extras for build requires - Add bootstrap conditional Spec URL: https://orion.fedorapeople.org/python-conda-package-streaming.spec SRPM URL: https://orion.fedorapeople.org/python-conda-package-streaming-0.7.0-3.fc38.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2150574 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
