https://bugzilla.redhat.com/show_bug.cgi?id=2150574 --- Comment #5 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- # THe deslected tests seem to require some kind of package server Typo THe. Typo deselected. Question out of curiosity (not a blocker for the package review): In %check, you set CONDA_EXE to %{_bindir}/conda. What is the default value? Also, I see upstream has a [test] extra that can be buildrequired with: %pyproject_buildrequires -x test Instead of # For tests BuildRequires: python%{python3_pkgversion}-boto3 BuildRequires: python%{python3_pkgversion}-bottle BuildRequires: python%{python3_pkgversion}-pytest BuildRequires: python%{python3_pkgversion}-pytest-mock However, it does not include conda. Should this require conda for tests in upstream? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2150574 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
