https://bugzilla.redhat.com/show_bug.cgi?id=2150574 Wayne Sun <gsun@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gsun@xxxxxxxxxx, | |mhroncok@xxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Wayne Sun <gsun@xxxxxxxxxx> --- This is informal review as I'm not sponsored. 1) The upstream is BSD 3-Clause License so in the spec the SPDX name should be BSD-3-Clause rather than BSD, detail could be found in: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_field https://docs.fedoraproject.org/en-US/legal/allowed-licenses/ 2) [OPINION] not use the %{srcname} in URL for easier access 3) [OPINION] define variable for description 4) [OPINION] use two empty lines between blocks from %prep to the end 5) no need to specify %license under %doc as it's handled by %{pyproject_files} Please check the fedora example file with 2,3,4,5: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_example_spec_file 6) Use %pytest in %check which no need to specify the $PYTHONPATH https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_pytest -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2150574 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
