https://bugzilla.redhat.com/show_bug.cgi?id=2085444 --- Comment #28 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- (In reply to xiangquan.liu from comment #27) > (In reply to Miro Hrončok from comment #26) > > I've been asked to provide some feedback on the specfile. > > > > > > > > > %undefine _auto_set_build_flags > > > %undefine __brp_mangle_shebangs > > > > This absolutely deserves an explanation in the spec file. Why is this > > needed? For the shebangs mangling, have you considered explicit opt-out for > > some files instead? IDeally, you want to get rid of this. > > I would like to explain these two lines. > %undefine _auto_set_build_flags - To avoid additional compile options from > rpmbuild since it may cause some compile errors for the package build. What exact flags cause what exact errors? There is no "may cause some compile errors". Either there are errors or there are not not. If there are errors, either some specific flags need to be disabled/changed with a rationale (a rationale is not "it may error" but rather "flag XY cannot be used because the code does ABC in GHJ") or the errors need to be fixed. Simple disabling all flags entirely does not make sense. If there are no errors, simply disabling the flags as prevention makes no sense. Considering the spec file compiles stuff with %make_build I am not even sure disabling auto_set_build_flags actually makes a difference. > %undefine __brp_mangle_shebangs - To avoid package build errors since these > python scripts(gdb plugins) are using internal python interpreter. What does "internal python interpreter" mean? If the files are not executed in classic shell by their shebang, do they even need to have shebangs and be executable? If they absolutely need to have "#!/usr/bin/env python" shebang and be executable (which I am reluctant to belive): - exclude the specific directory/files from the shebang mangling, don't disable it: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shebang_lines - explain int the comment why this unusual and dangerous sehabng is actually needed to;dr Please try to avoid those lines as much as possible and if you cannot, explain why (int he spec), instead of explaining what those two lines do to me (I know what the lines do). -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2085444 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
