[Bug 2085444] Review Request: sgx-sdk - Software Guard eXtension software development kit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2085444



--- Comment #27 from xiangquan.liu@xxxxxxxxx ---
(In reply to Miro Hrončok from comment #26)
> I've been asked to provide some feedback on the specfile.
> 
> 
> 
> > %undefine _auto_set_build_flags
> > %undefine __brp_mangle_shebangs
> 
> This absolutely deserves an explanation in the spec file. Why is this
> needed? For the shebangs mangling, have you considered explicit opt-out for
> some files instead? IDeally, you want to get rid of this.

I would like to explain these two lines.
%undefine _auto_set_build_flags - To avoid additional compile options from
rpmbuild since it may cause some compile errors for the package build.
%undefine __brp_mangle_shebangs - To avoid package build errors since these
python scripts(gdb plugins) are using internal python interpreter. 
*** ERROR: ambiguous python shebang in
/usr/lib64/sgx-gdb-plugin/gdb_sgx_plugin.py: #!/usr/bin/env python. Change it
to python3 (or python2) explicitly.
*** ERROR: ambiguous python shebang in
/usr/lib64/sgx-gdb-plugin/load_symbol_cmd.py: #!/usr/bin/env python. Change it
to python3 (or python2) explicitly.
*** ERROR: ambiguous python shebang in /usr/lib64/sgx-gdb-plugin/readelf.py:
#!/usr/bin/env python. Change it to python3 (or python2) explicitly.
*** ERROR: ambiguous python shebang in /usr/lib64/sgx-gdb-plugin/sgx_emmt.py:
#!/usr/bin/env python. Change it to python3 (or python2) explicitly.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2085444
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux