[Bug 2148616] Review request: clBLAS An OpenCL BLAS library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2148616



--- Comment #4 from Benson Muite <benson_muite@xxxxxxxxxxxxx> ---
a) There are two files which are public domain. The license field in the spec
should be updated to reflect this.
A breakdown of the licensing should also be added to the spec, ie. indicate the
two files which are public domain
and indicate rest of files are Apache 2.
b1) Can you do
Export CL_TARGET_OPENCL_VERSION=3
or
Export CL_TARGET_OPENCL_VERSION=2
Maybe some discussion is needed on the mailing list or heterogeneous sig
as to reasonable defaults for this.

Other comments:

May want to use the macro %{_docdir} see
https://fedoraproject.org/wiki/User:Tibbs/RPMMacros

If the tests take a long time, make them conditional, and try some of the
samples:
https://github.com/clMathLibraries/clBLAS/tree/master/src/samples


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2148616
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux